geido commented on PR #20891: URL: https://github.com/apache/superset/pull/20891#issuecomment-1209656834
First of all, this looks great! A few minor issues that I found: - Not a big deal, but you can click way after the number in the Big Number <img width="1309" alt="Screenshot 2022-08-09 at 19 50 27" src="https://user-images.githubusercontent.com/60598000/183710724-8113ee02-2cb8-4bde-a296-a2da46802c0a.png";> - Another small one. It would be great if the dropdown could be shown in the upper side when it does not have enough visible space to save some of the scrolling <img width="1012" alt="Screenshot 2022-08-09 at 19 59 34" src="https://user-images.githubusercontent.com/60598000/183712551-33c26e52-12a0-4b40-b5ad-d7e0e424d3a4.png";> - In a graph chart we can only click on the line but not on the node, is that normal? - One more thing about the graph is that when right-clicking the animation is triggered and it creates confusion as the nodes start moving. Not sure if there is a way to stop the chart animation when right-clicking - For some reasons, when trying to close the dropdown by clicking 2 or 3 px from its left side, it won't close. I found it annoying for the user as I ended up clicking a few times to try closing it up. For some reasons, it does not happen if you click on any other side, even 1 px away from its side. This is an Antdesign issue though. Just pointing out if there is a quick fix. I believe the above are all minor issues that we can handle in separate PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/60598000/183710724-8113ee02-2cb8-4bde-a296-a2da46802c0a.png"](https://user-images.githubusercontent.com/60598000/183710724-8113ee02-2cb8-4bde-a296-a2da46802c0a.png"){kind=link}
![https://user-images.githubusercontent.com/60598000/183712551-33c26e52-12a0-4b40-b5ad-d7e0e424d3a4.png"](https://user-images.githubusercontent.com/60598000/183712551-33c26e52-12a0-4b40-b5ad-d7e0e424d3a4.png"){kind=link}