michael-s-molina commented on PR #21094: URL: https://github.com/apache/superset/pull/21094#issuecomment-1225972219
> This makes sense but I still believe we should not have all the shared parts under one utils file even though this is not very big. For instance, I don't see why styles should be under utils. Maybe I was not clear but in my example styles would never be under utils. It would belong to the component file if we have a few of them, or to a styles submodule if we have many. So I think we're in agreement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
