michael-s-molina commented on code in PR #21094:
URL: https://github.com/apache/superset/pull/21094#discussion_r968409004
##########
superset-frontend/src/components/Select/AsyncSelect.tsx:
##########
@@ -30,61 +30,62 @@ import React, {
useImperativeHandle,
} from 'react';
import { ensureIsArray, styled, t } from '@superset-ui/core';
-import AntdSelect, {
- SelectProps as AntdSelectProps,
- SelectValue as AntdSelectValue,
- LabeledValue as AntdLabeledValue,
-} from 'antd/lib/select';
-import { DownOutlined, SearchOutlined } from '@ant-design/icons';
-import { Spin } from 'antd';
+import { LabeledValue as AntdLabeledValue } from 'antd/lib/select';
import debounce from 'lodash/debounce';
import { isEqual } from 'lodash';
import Icons from 'src/components/Icons';
import { getClientErrorObject } from 'src/utils/getClientErrorObject';
import { SLOW_DEBOUNCE } from 'src/constants';
-import { rankedSearchCompare } from 'src/utils/rankedSearchCompare';
-import { getValue, hasOption, isLabeledValue } from './utils';
-
-const { Option } = AntdSelect;
-
-type AntdSelectAllProps = AntdSelectProps<AntdSelectValue>;
-
-type PickedSelectProps = Pick<
- AntdSelectAllProps,
- | 'allowClear'
- | 'autoFocus'
- | 'disabled'
- | 'filterOption'
- | 'loading'
- | 'notFoundContent'
- | 'onChange'
- | 'onClear'
- | 'onFocus'
- | 'onBlur'
- | 'onDropdownVisibleChange'
- | 'placeholder'
- | 'showSearch'
- | 'tokenSeparators'
- | 'value'
- | 'getPopupContainer'
->;
-
-export type OptionsType = Exclude<AntdSelectAllProps['options'], undefined>;
-
-export type OptionsTypePage = {
- data: OptionsType;
- totalCount: number;
-};
-
-export type OptionsPagePromise = (
- search: string,
- page: number,
- pageSize: number,
-) => Promise<OptionsTypePage>;
+import {
+ getValue,
+ hasOption,
+ isLabeledValue,
+ DEFAULT_SORT_COMPARATOR,
+ EMPTY_OPTIONS,
+ MAX_TAG_COUNT,
+ SelectOptionsPagePromise,
+ SelectOptionsType,
+ SelectOptionsTypePage,
+ StyledCheckOutlined,
+ StyledStopOutlined,
+ TOKEN_SEPARATORS,
+ renderSelectOptions,
+ StyledContainer,
+ StyledSelect,
+ hasCustomLabels,
+ BaseSelectProps,
+ sortSelectedFirstHelper,
+ sortComparatorWithSearchHelper,
+ sortComparatorForNoSearchHelper,
+ getSuffixIcon,
+ dropDownRenderHelper,
+ handleFilterOptionHelper,
+} from './utils';
+
+const StyledError = styled.div`
+ ${({ theme }) => `
+ display: flex;
+ justify-content: center;
+ align-items: flex-start;
+ width: 100%;
+ padding: ${theme.gridUnit * 2}px;
+ color: ${theme.colors.error.base};
+ & svg {
+ margin-right: ${theme.gridUnit * 2}px;
+ }
+ `}
+`;
+
+const StyledErrorMessage = styled.div`
+ overflow: hidden;
+ text-overflow: ellipsis;
+`;
+
+const DEFAULT_PAGE_SIZE = 100;
export type AsyncSelectRef = HTMLInputElement & { clearCache: () => void };
-export interface AsyncSelectProps extends PickedSelectProps {
+export interface AsyncSelectProps extends BaseSelectProps {
Review Comment:
Can you remove from `SelectProps` and `AsyncSelectProps` the properties that
are already declared in `BaseSelectProps`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
