john-bodley opened a new pull request, #21344: URL: https://github.com/apache/superset/pull/21344
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY As noted in [this](https://apache-superset.slack.com/archives/G013HAE6Y0K/p1662183800347719) Slack thread Airbnb ran into an issue where a regression in the FAB API resulted in us deleting almost all our metrics in the metadata database rather than those associated with the table we believed we were filtering by. This PR doesn't remedy said issue, however it exposes the `table_id` column as a listable column for the SqlMetricInlineView and TableColumnInlineView classes so we can validate that the response payload is correct, i.e., if we have a query like `/tablecolumninlineview/api/read?_flt_0_table_id=1` we can then assert that all the `table_id`s match the specified filter. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS Tested the two API read endpoints locally and confirmed the `table_id` column was included. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
