john-bodley commented on code in PR #21344:
URL: https://github.com/apache/superset/pull/21344#discussion_r963928494
##########
superset/connectors/sqla/views.py:
##########
@@ -93,14 +93,15 @@ class TableColumnInlineView( # pylint:
disable=too-many-ancestors
]
add_columns = edit_columns
list_columns = [
- "column_name",
Review Comment:
ABC. The only actual change is the inclusion of the `table_id` column.
##########
superset/connectors/sqla/views.py:
##########
@@ -210,7 +211,13 @@ class SqlMetricInlineView( # pylint:
disable=too-many-ancestors
add_title = _("Add Metric")
edit_title = _("Edit Metric")
- list_columns = ["metric_name", "verbose_name", "metric_type", "extra"]
+ list_columns = [
Review Comment:
ABC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
