villebro commented on code in PR #21931:
URL: https://github.com/apache/superset/pull/21931#discussion_r1005964332
##########
superset/reports/commands/execute.py:
##########
@@ -698,6 +711,6 @@ def validate( # pylint: disable=arguments-differ
self._model_id,
self._execution_id,
)
- self._model = ReportScheduleDAO.find_by_id(self._model_id,
session=session)
+ self._model =
session.query(ReportSchedule).filter_by(id=self._model_id).first()
Review Comment:
When executing these reports async, we can't use the DAO here, as that uses
the base filter that checks `g.user` which isn't set yet (later when we want to
execute the report we need to know who the creator/modifier/owner is if we're
not executing as the thumbs selenium user).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
