villebro opened a new pull request, #21931:
URL: https://github.com/apache/superset/pull/21931

   ### SUMMARY
   Currently Alerts & Reports only supports executing the report and alert 
queries as the `THUMBNAIL_SELENIUM_USER`. This can be problematic in a scenario 
where user impersonation is enabled and there isn't a service account that has 
full access to all datasources or Superset objects.
   
   To remedy this, this PR adds a config option `ALERT_REPORTS_EXECUTE_AS` 
making it possible to execute reports as
   1. the owner (whichever is first returned in the case of multiple owners)
   2. the creator
   3. the last modifier
   4. the `THUMBNAIL_SELENIUM_USER`
   
   The config is a list of values, meaning that if the first option isn't found 
(e.g. in the case of alerts/reports created programmatically where the 
`created_by`, `changed_by` or `owners` is undefined), it will move to the next 
option. By default it will be set to use the `selenium` user so as to not 
introduce a breaking change.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to