codyml opened a new pull request, #22260: URL: https://github.com/apache/superset/pull/22260
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR fixes a typing error that enabled an undefined key access error: `dataMask` isn't guaranteed to exist on type `FilterWithDataMask` because the source of that key, `DataMaskStateWithId`, isn't guaranteed to have a value for each filter ID. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> Example of error: <img width="1792" alt="204566163-6539cf34-efa5-44d4-93bd-3fa1a90919a8" src="https://user-images.githubusercontent.com/13007381/204578285-a0038f65-c439-4eb0-9fab-798f092111db.png";> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> I had trouble reproducing this issue locally, but try various combinations of filled and unfilled filters and ensure that it doesn't happen again. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [x] Required feature flags: `HORIZONTAL_FILTER_BAR` - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/13007381/204578285-a0038f65-c439-4eb0-9fab-798f092111db.png"](https://user-images.githubusercontent.com/13007381/204578285-a0038f65-c439-4eb0-9fab-798f092111db.png"){kind=link}