zhaoyongjie commented on code in PR #22260:
URL: https://github.com/apache/superset/pull/22260#discussion_r1035442923
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx:
##########
@@ -128,7 +128,7 @@ const FilterControls: FC<FilterControlsProps> = ({
const activeOverflowedFiltersInScope = useMemo(
() =>
overflowedFiltersInScope.filter(
- filter => isNativeFilter(filter) && filter.dataMask.filterState?.value,
+ filter => isNativeFilter(filter) &&
filter.dataMask?.filterState?.value,
Review Comment:
Currently, there are `isNativeFilter` and `isFilterDivider` as the type
guard, so I think we should introduce a new type guard for this use case, for
example, `isFilterWithDataMask`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
