lyndsiWilliams opened a new pull request, #22262: URL: https://github.com/apache/superset/pull/22262
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR implements the following polishes: - Pagination on the table should be 25 by default (previously set to 10) - Align refresh buttons in the left panel - Align width of selected tables in left panel with search input - The width was only wrong when there was no scrollbar present. I implemented a function to detect if a scrollbar is present and apply padding only if there is no scrollbar - Remove save button and `...` dropdown menu from the top right of the header - An `editing` prop was added in the header component so that it can be reused when building the edit dataset component - Brought the "Manage your databases here" blank state from SQL lab to the left panel - Fixed a bug where the table wouldn't take the full height of the dataset panel when there is no "This table already has a dataset" banner at the top ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> #### BEFORE: <img width="1189" alt="createDSbefore" src="https://user-images.githubusercontent.com/55605634/204584095-c895da39-a00b-41a1-8fa7-b4f45ec1e4e2.png";> #### AFTER: <img width="1189" alt="1234createDSpolish" src="https://user-images.githubusercontent.com/55605634/204584222-75cfe0a0-dda9-4c0b-a19f-18294649794d.png";>  ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> - Go to `http://localhost:9000/dataset/add/?testing` - Select a database and a schema - Select a schema with over 25 pages to see default for pagination - Observe all the changes described above ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/55605634/204584095-c895da39-a00b-41a1-8fa7-b4f45ec1e4e2.png"](https://user-images.githubusercontent.com/55605634/204584095-c895da39-a00b-41a1-8fa7-b4f45ec1e4e2.png"){kind=link}
![https://user-images.githubusercontent.com/55605634/204584222-75cfe0a0-dda9-4c0b-a19f-18294649794d.png"](https://user-images.githubusercontent.com/55605634/204584222-75cfe0a0-dda9-4c0b-a19f-18294649794d.png"){kind=link}
