kgabryje opened a new pull request, #22362:
URL: https://github.com/apache/superset/pull/22362
### SUMMARY
When user was tried to reorder native filters placed in overflow dropdown in
horizontal bar, the visual changes were not applied and filters were rendered
in the same order as before. The problem was using a `key` property around
rendered filter - since the `key={id}` wasn't changing when filters were
reordered, React ignored the change and didn't redraw the filters.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
https://user-images.githubusercontent.com/15073128/206274030-796e9535-7e09-49ea-a13a-0bb8a0e775cf.mov
After:
https://user-images.githubusercontent.com/15073128/206273709-c5e0b358-3769-4ba6-847c-ae7473c50f63.mov
### TESTING INSTRUCTIONS
1. Enable `HORIZONTAL_FILTERS_BAR` ff
2. Add some filters, enough to make the overflow button appear
3. Reorder filters rendered in the overflow dropdown
4. Verify that those filters are indeed reordered after saving
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
