eschutho commented on code in PR #21912: URL: https://github.com/apache/superset/pull/21912#discussion_r1044890310
########## superset/databases/ssh_tunnel/models.py: ########## @@ -0,0 +1,86 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from typing import Any, Dict + +import sqlalchemy as sa +from flask import current_app +from flask_appbuilder import Model +from sqlalchemy.orm import backref, relationship +from sqlalchemy_utils import EncryptedType + +from superset.constants import SSH_TUNNELLING_LOCAL_BIND_ADDRESS +from superset.models.core import Database +from superset.models.helpers import ( + AuditMixinNullable, + ExtraJSONMixin, + ImportExportMixin, +) + +app_config = current_app.config + + +class SSHTunnel(Model, AuditMixinNullable, ExtraJSONMixin, ImportExportMixin): + """ + A ssh tunnel configuration in a database. + """ + + __tablename__ = "ssh_tunnels" Review Comment: I don't think we have a written convention, but agree that we should. 👍 I would also vote for plural long-term. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
