dpgaspar commented on code in PR #22355:
URL: https://github.com/apache/superset/pull/22355#discussion_r1062282117
##########
tests/integration_tests/datasource_tests.py:
##########
@@ -543,7 +543,7 @@ def test_get_samples_with_filters(test_client,
login_as_admin, virtual_dataset):
f"/datasource/samples?datasource_id={virtual_dataset.id}&datasource_type=table"
)
rv = test_client.post(uri, json=None)
- assert rv.status_code == 200
+ assert rv.status_code == 400
Review Comment:
why did this changed to a 400 now?
##########
tests/integration_tests/conftest.py:
##########
@@ -188,7 +188,11 @@ def remove(self) -> None:
def setup_presto_if_needed():
- backend = app.config["SQLALCHEMY_EXAMPLES_URI"].split("://")[0]
+ db_uri = (
+ app.config.get("SQLALCHEMY_EXAMPLES_URI")
+ or app.config["SQLALCHEMY_DATABASE_URI"]
+ )
+ backend = db_uri.split("://")[0]
Review Comment:
this seems like an unrelated change, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
