EugeneTorap commented on code in PR #22355:
URL: https://github.com/apache/superset/pull/22355#discussion_r1062296982
##########
tests/integration_tests/conftest.py:
##########
@@ -188,7 +188,11 @@ def remove(self) -> None:
def setup_presto_if_needed():
- backend = app.config["SQLALCHEMY_EXAMPLES_URI"].split("://")[0]
+ db_uri = (
+ app.config.get("SQLALCHEMY_EXAMPLES_URI")
+ or app.config["SQLALCHEMY_DATABASE_URI"]
+ )
+ backend = db_uri.split("://")[0]
Review Comment:
It's the related change. When you want to run local test with
`SQLALCHEMY_EXAMPLES_URI = None` you will have an exception here and I fix the
issue.
> URI to database storing the example data, points to
SQLALCHEMY_DATABASE_URI by default if set to `None`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
