john-bodley commented on code in PR #22413:
URL: https://github.com/apache/superset/pull/22413#discussion_r1048744544
##########
superset/connectors/sqla/models.py:
##########
@@ -226,8 +226,8 @@ class TableColumn(Model, BaseColumn, CertificationMixin):
table_id = Column(Integer, ForeignKey("tables.id"))
table: SqlaTable = relationship(
"SqlaTable",
- backref=backref("columns", cascade="all, delete-orphan"),
- foreign_keys=[table_id],
+ back_populates="columns",
Review Comment:
`backrefs`, per [here](https://docs.sqlalchemy.org/en/14/orm/backref.html),
is deemed legacy though is used in some instances—such as the database <> table
relationship given how/where the code is defined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
