john-bodley commented on code in PR #22413:
URL: https://github.com/apache/superset/pull/22413#discussion_r1071524955
##########
superset/connectors/sqla/models.py:
##########
@@ -535,16 +542,25 @@ def _process_sql_expression(
class SqlaTable(Model, BaseDatasource): # pylint:
disable=too-many-public-methods
- """An ORM object for SqlAlchemy table references"""
+ """An ORM object for SqlAlchemy table references."""
type = "table"
query_language = "sql"
is_rls_supported = True
- columns: List[TableColumn] = []
- metrics: List[SqlMetric] = []
+ columns: Mapped[List[TableColumn]] = relationship(
Review Comment:
Ideally we would use `lazy="selectin"` rather than `lazy="select"` (default)
but this seems to be causing downstream issues with the associated
`sqlatable_user` table. My current hunch is the `selectin` option is rather new
and there's been a number of
[reported](https://github.com/sqlalchemy/sqlalchemy/issues?q=is%3Aissue+selectin+is%3Aclosed)
issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
