xtinec commented on a change in pull request #7121: [SQL Lab] fix table 
metadata loading spinner
URL: 
https://github.com/apache/incubator-superset/pull/7121#discussion_r268894044
 
 

 ##########
 File path: superset/assets/src/SqlLab/components/TableElement.jsx
 ##########
 @@ -190,7 +192,11 @@ class TableElement extends React.PureComponent {
         </div>
         <div className="pull-right">
           {table.isMetadataLoading || table.isExtraMetadataLoading ?
-            <Loading size={50} />
+            <Loading
+              size={50}
+              position="normal"
+              styleOverrides={STYLE_ZERO_MARGIN}
 
 Review comment:
   Can we do this by defining `margin: 0` in a ccs class and add that css class 
to the `Loading` component?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to