xtinec commented on a change in pull request #7121: [SQL Lab] fix table
metadata loading spinner
URL:
https://github.com/apache/incubator-superset/pull/7121#discussion_r269254161
##########
File path: superset/assets/src/components/Loading.jsx
##########
@@ -37,15 +39,15 @@ const FLOATING_STYLE = {
transform: 'translate(-50%, -50%)',
};
-export default function Loading({ size, position }) {
+export default function Loading({ size, position, className }) {
const style = position === 'floating' ? FLOATING_STYLE : {};
const styleWithWidth = {
...style,
size,
};
return (
<img
- className="loading"
+ className={'loading ' + className}
Review comment:
[nit] Using string interpolation, \`loading ${className}\`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
