kgabryje opened a new pull request, #23575: URL: https://github.com/apache/superset/pull/23575
### SUMMARY This PR enables opening Drill By chart in Explore. The feature is similar to "Edit chart" in Dashboard, except in this case we treat the drill by result as a completely new chart - which means that we don't preserve the original chart's id or name. Additionally, the filters inherited from dashboard (native filters, cross filters) are not treated as "extra" filters, which means they will get saved with the chart (as opposed to editing an existing chart from the dashboard). ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF https://user-images.githubusercontent.com/15073128/229819841-96b70a63-3d48-451b-a4c7-40d96c5e545a.mov ### TESTING INSTRUCTIONS 0. Enable `DRILL_BY` ff 1. Right click on a series -> drill by -> column 2. In drill by modal, click (or right click to open in new tab) "Edit chart" 3. You should see exactly the same chart in Explore as it was in the drill by modal. Compared to original chart, the adhoc filters have additional filter equal to clicked series appended, and groupby is replaced by clicked column. 4. If there were any native filters or cross filters in the dashboard, they are added as adhoc filters in Explore, but NOT as "extra" filters - they don't have the warning icon and they will get saved with the chart. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
