kgabryje commented on PR #23575: URL: https://github.com/apache/superset/pull/23575#issuecomment-1497104946
> Very exciting stuff! 😻 LGTM with a very optional typing improvement idea (if it feels like over abstraction it probably is, so feel free to ignore). Also, not something that needs to be addressed in this PR, but... I _really_ wanted to see if I was able to drill further down into the chart 😆, and I was slightly 😿 when the context menu didn't show up: <img alt="image" width="897" src="https://user-images.githubusercontent.com/33317356/230020788-9ca99114-1bd2-409c-958e-0bcdf7d8cff6.png";> > > Also, it would be nice if the drilling dimensions were somehow displayed in the drill down modal (I assume this is something that's planned for a future PR). Both coming soon! 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/33317356/230020788-9ca99114-1bd2-409c-958e-0bcdf7d8cff6.png"](https://user-images.githubusercontent.com/33317356/230020788-9ca99114-1bd2-409c-958e-0bcdf7d8cff6.png"){kind=link}