dpgaspar commented on code in PR #23965:
URL: https://github.com/apache/superset/pull/23965#discussion_r1191332308
##########
tests/integration_tests/db_engine_specs/base_engine_spec_tests.py:
##########
@@ -447,17 +447,19 @@ def test_validate_parameters_missing():
"query": {},
}
}
- errors = BasicParametersMixin.validate_parameters(properties)
- assert errors == [
- SupersetError(
- message=(
- "One or more parameters are missing: " "database, host, port,
username"
+ with app.app_context():
Review Comment:
SupersetError uses flask-babel that needs an app context, Flask is stricter
now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
