dpgaspar commented on code in PR #23965:
URL: https://github.com/apache/superset/pull/23965#discussion_r1191339774


##########
tests/integration_tests/charts/data/api_tests.py:
##########
@@ -1188,10 +1193,10 @@ def test_data_cache_default_timeout(
 
 
 def test_chart_cache_timeout(
+    load_energy_table_with_slice: List[Slice],

Review Comment:
   This is an interesting case that surfaced on this new Flask version. Flask 
now is stricter, so when popping a new context from the app stack it checks if 
the context is the one we are expecting. `load_energy_table_with_slice` creates 
a new `app_context` so it needs to be first



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to