john-bodley commented on code in PR #24129:
URL: https://github.com/apache/superset/pull/24129#discussion_r1199241434
##########
tests/integration_tests/charts/data/api_tests.py:
##########
@@ -444,11 +444,11 @@ def test_chart_data_dttm_filter(self):
else:
raise Exception("ds column not found")
+ @pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
Review Comment:
I'm really not sure how this test worked before without the inclusion of the
fixture which ensures (hopefully) that the tests are idempotent.
##########
superset/utils/pandas_postprocessing/prophet.py:
##########
@@ -134,7 +135,11 @@ def prophet( # pylint: disable=too-many-arguments
raise InvalidPostProcessingError(_("DataFrame include at least one
series"))
target_df = DataFrame()
- for column in [column for column in df.columns if column != index]:
+ for column in [
Review Comment:
@villebro I've love your input on this as I'm somewhat perplexed as to how
this was working. After reenabling the tests it seemed to be trying to fit
non-numerical columns within the `pd.DataFrame`. I couldn't find any options
where we explicitly define which columns to produce a forecast for.
##########
tests/integration_tests/charts/data/api_tests.py:
##########
@@ -476,7 +476,7 @@ def test_chart_data_prophet(self):
self.assertIn("sum__num__yhat", row)
self.assertIn("sum__num__yhat_upper", row)
self.assertIn("sum__num__yhat_lower", row)
- self.assertEqual(result["rowcount"], 47)
+ self.assertEqual(result["rowcount"], 103)
Review Comment:
I'm not sure if 47 or 103 is correct. I assume these tests have been
disabled for a long time and thus the underlying data might have changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
