john-bodley commented on code in PR #24129:
URL: https://github.com/apache/superset/pull/24129#discussion_r1199241434


##########
tests/integration_tests/charts/data/api_tests.py:
##########
@@ -444,11 +444,11 @@ def test_chart_data_dttm_filter(self):
         else:
             raise Exception("ds column not found")
 
+    @pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")

Review Comment:
   I'm really not sure how this test worked before it was skipped without the 
inclusion of the fixture which ensures (hopefully) that the tests are 
idempotent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to