john-bodley commented on code in PR #24488:
URL: https://github.com/apache/superset/pull/24488#discussion_r1239084491
##########
superset/datasets/commands/delete.py:
##########
@@ -43,19 +41,13 @@ def __init__(self, model_id: int):
def run(self) -> Model:
self.validate()
- self._model = cast(SqlaTable, self._model)
+ assert self._model
+
try:
- # Even though SQLAlchemy should in theory delete rows from the
association
Review Comment:
@betodealmeida this should address the problem you were trying to circumvent
in https://github.com/apache/superset/pull/23414.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
