john-bodley commented on code in PR #24488:
URL: https://github.com/apache/superset/pull/24488#discussion_r1239257301
##########
superset/utils/core.py:
##########
@@ -849,6 +851,19 @@ def ping_connection(connection: Connection, branch: bool)
-> None:
# restore 'close with result'
connection.should_close_with_result = save_should_close_with_result
+ if some_engine.dialect.name == "sqlite":
Review Comment:
I wonder if this is why a number of tests currently have,
```python
if backend() == "sqlite":
return
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
