john-bodley commented on code in PR #24649:
URL: https://github.com/apache/superset/pull/24649#discussion_r1260011039
##########
setup.py:
##########
@@ -178,7 +178,7 @@ def get_git_sha() -> str:
"trino": ["trino>=0.324.0"],
"prophet": ["prophet>=1.0.1, <1.1", "pystan<3.0"],
"redshift": ["sqlalchemy-redshift>=0.8.1, < 0.9"],
- "rockset": ["rockset>=0.8.10, <0.9"],
+ "rockset": ["rockset-sqlalchemy>=0.0.1"],
Review Comment:
@gadhagod thanks for the PR. Yould you mind including an upper bound
(exclusive of) the next major version—assuming it adheres to the symver
construct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
