john-bodley commented on code in PR #24649:
URL: https://github.com/apache/superset/pull/24649#discussion_r1260305237


##########
docs/docs/databases/installing-database-drivers.mdx:
##########
@@ -51,15 +51,16 @@ Some of the recommended packages are shown below. Please 
refer to [setup.py](htt
 | [MySQL](/docs/databases/mysql)                            | `pip install 
mysqlclient`                                                          | 
`mysql://<UserName>:<DBPassword>@<Database Host>/<Database Name>`               
                            |
 | [Oracle](/docs/databases/oracle)                          | `pip install 
cx_Oracle`                                                            | 
`oracle://`                                                                     
                            |
 | [PostgreSQL](/docs/databases/postgres)                    | `pip install 
psycopg2`                                                             | 
`postgresql://<UserName>:<DBPassword>@<Database Host>/<Database Name>`          
                            |
-| [Trino](/docs/databases/trino)                            | `pip install 
trino`                                                                | 
`trino://{username}:{password}@{hostname}:{port}/{catalog}`                     
                            |
 | [Presto](/docs/databases/presto)                          | `pip install 
pyhive`                                                               | 
`presto://`                                                                     
                            |
+| [Rockset](/docs/databases/rockset)                        | `pip install 
rockset-sqlalchemy`                                                   | 
`rockset://<api_key>:@<api_server>`
 | [SAP Hana](/docs/databases/hana)                          | `pip install 
hdbcli sqlalchemy-hana or pip install apache-superset[hana]`          | 
`hana://{username}:{password}@{host}:{port}`                                    
                            |
 | [StarRocks](/docs/databases/starrocks)                    | `pip install 
starrocks`                                                            | 
`starrocks://<User>:<Password>@<Host>:<Port>/<Catalog>.<Database>`              
                            |
 | [Snowflake](/docs/databases/snowflake)                    | `pip install 
snowflake-sqlalchemy`                                                 | 
`snowflake://{user}:{password}@{account}.{region}/{database}?role={role}&warehouse={warehouse}`
             |
 | SQLite                                                    | No additional 
library needed                                                       | 
`sqlite://`                                                                     
                            |
 | [SQL Server](/docs/databases/sql-server)                  | `pip install 
pymssql`                                                              | 
`mssql+pymssql://`                                                              
                                    |
 | [Teradata](/docs/databases/teradata)                      | `pip install 
teradatasqlalchemy`                                                   | 
`teradatasql://{user}:{password}@{host}`                                        
                            |
 | [TimescaleDB](/docs/databases/timescaledb)                | `pip install 
psycopg2`                                                             | 
`postgresql://<UserName>:<DBPassword>@<Database Host>:<Port>/<Database Name>`   
                            |
+| [Trino](/docs/databases/trino)                            | `pip install 
trino`                                                                | 
`trino://{username}:{password}@{hostname}:{port}/{catalog}`                     
                            |

Review Comment:
   Thanks for making this ABC.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to