villebro commented on code in PR #25126:
URL: https://github.com/apache/superset/pull/25126#discussion_r1327787093
##########
superset/connectors/sqla/models.py:
##########
@@ -1007,6 +1007,8 @@ def adhoc_column_to_sqla( # pylint:
disable=too-many-locals
qry = sa.select([sqla_column]).limit(1).select_from(tbl)
sql = self.database.compile_sqla_query(qry)
col_desc = get_columns_description(self.database,
self.schema, sql)
+ if not col_desc:
Review Comment:
@kgabryje I agree - however, as it will be lots of work to clean up old
metadata, I think we can maybe have both?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
