zhaoyongjie commented on code in PR #25126:
URL: https://github.com/apache/superset/pull/25126#discussion_r1336068788
##########
tests/integration_tests/charts/data/api_tests.py:
##########
@@ -943,6 +944,71 @@ def test_chart_data_get(self):
assert data["result"][0]["status"] == "success"
assert data["result"][0]["rowcount"] == 2
+ @pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
+ def test_chart_data_get_with_x_axis_using_custom_sql(self):
+ """
+ Chart data API: Test GET endpoint
+ """
+ chart = db.session.query(Slice).filter_by(slice_name="Genders").one()
+ chart.query_context = json.dumps(
+ {
+ "datasource": {"id": chart.table.id, "type": "table"},
+ "force": False,
+ "queries": [
+ {
+ "time_range": "1900-01-01T00:00:00 :
2000-01-01T00:00:00",
+ "granularity": "ds",
+ "filters": [
+ {"col": "ds", "op": "TEMPORAL_RANGE", "val": "No
filter"}
+ ],
+ "extras": {
+ "having": "",
+ "where": "",
+ },
+ "applied_time_extras": {},
+ "columns": [
+ {
+ "columnType": "BASE_AXIS",
+ "datasourceWarning": False,
+ "expressionType": "SQL",
+ "label": "My column",
+ "sqlExpression": "ds",
+ "timeGrain": "P1W",
+ }
+ ],
Review Comment:
the "time_range" and "filters" in query_object is same logic as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
