kasiazjc commented on PR #25542: URL: https://github.com/apache/superset/pull/25542#issuecomment-1757526715
@justinpark thank you for working on this, definitely a needed feature! I have a few suggestions: - I would switch the columns on action and shortcut - it is easier to scan the text and look for keywords that way, and we do not have to worry about truncation if there are more than 2 shortcuts <img width="1436" alt="image" src="https://github.com/apache/superset/assets/36897697/5ceb1c4e-1407-4821-b4a0-5f251444b175";> - I changed shortcut fontsize to 12px - 14px seemed to be overly cluttering the modal - I think this feature is not needed to be available at all times - people will probably quickly learn shortcuts and only open the modal to refresh the memory, so I would suggest moving it to the "..." dropdown with autocomplete, as this bar has a bunch of buttons already What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
