Re: [PR] feat(sqllab): Add keyboard shortcut helper [superset]

Wed, 11 Oct 2023 09:21:33 -0700 


kasiazjc commented on PR #25542:
URL: https://github.com/apache/superset/pull/25542#issuecomment-1758056019

   > > * I would switch the columns on action and shortcut - it is easier to 
scan the text and look for keywords that way, and we do not have to worry about 
truncation if there are more than 2 shortcuts
   > > 
   > > <img alt="image" width="1436" 
src="https://user-images.githubusercontent.com/36897697/274261903-5ceb1c4e-1407-4821-b4a0-5f251444b175.png";>
   > > * I changed shortcut fontsize to 12px - 14px seemed to be overly 
cluttering the modal
   > > * I think this feature is not needed to be available at all times - 
people will probably quickly learn shortcuts and only open the modal to refresh 
the memory, so I would suggest moving it to the "..." dropdown with 
autocomplete, as this bar has a bunch of buttons already
   > > What do you think?
   > 
   > @kasiazjc Thanks for the suggestion! I made the layout change and menu 
location as you suggested. <img alt="Screenshot 2023-10-11 at 10 39 04 AM" 
width="1131" 
src="https://user-images.githubusercontent.com/1392866/274314088-b1e92de0-a434-4a17-b039-522537c72117.png";>
   > 
   > <img alt="Screenshot 2023-10-11 at 9 14 29 AM" width="1123" 
src="https://user-images.githubusercontent.com/1392866/274314134-a5a945a0-c051-46ee-b647-24aabba24bfd.png";>
   
   Thank you for the quick changes, this looks great! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to