rtexelm commented on code in PR #26202:
URL: https://github.com/apache/superset/pull/26202#discussion_r1475217977
##########
superset-frontend/src/components/CronPicker/CronPicker.tsx:
##########
@@ -44,7 +44,7 @@ export const LOCALE: Locale = {
prefixMonths: t('in'),
prefixMonthDays: t('on'),
prefixWeekDays: t('on'),
- prefixWeekDaysForMonthAndYearPeriod: t('and'),
+ prefixWeekDaysForMonthAndYearPeriod: t('or'),
Review Comment:
This one was from a suggestion in a comment on [this
ticket](https://app.shortcut.com/preset/story/77442/combine-on-and-and-to-the-same-line-in-weekly-schedule).
Zef thought it makes more sense because the cron fires if either are true like
an OR statement, but, it can be troubling if your reading it as natural
language. Not sure what is more appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
