rtexelm commented on code in PR #26202:
URL: https://github.com/apache/superset/pull/26202#discussion_r1475328885


##########
superset-frontend/src/features/alerts/components/NotificationMethod.tsx:
##########
@@ -133,25 +136,29 @@ export const NotificationMethod: 
FunctionComponent<NotificationMethodProps> = ({
               )}
               value={method}
             />
+            {method !== undefined && index !== 0 && !!onRemove ? (

Review Comment:
   @fisjac might want to look at this as well. This one was from [this 
ticket](https://app.shortcut.com/preset/story/77355/notification-method-bugs). 
I removed the option to add another method unless there is `> 1` method in 
`allowedNotificationMethods`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to