mistercrunch commented on code in PR #27030:
URL: https://github.com/apache/superset/pull/27030#discussion_r1482274906
##########
superset-frontend/src/components/AlteredSliceTag/index.tsx:
##########
@@ -27,53 +26,84 @@ import { Tooltip } from 'src/components/Tooltip';
import ModalTrigger from '../ModalTrigger';
import TableView from '../TableView';
-const propTypes = {
- origFormData: PropTypes.object.isRequired,
- currentFormData: PropTypes.object.isRequired,
-};
+// Define interfaces for props and state
+interface FormData {
+ [key: string]: any; // Use a more specific type if possible for your form
data
Review Comment:
the type FormData has to be defined somewhere else (?) it's one of those
used all over the codebase. I couldn't find a reference, but seems it'd belong
here `packages/superset-ui-core/src/types/index.ts` maybe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
