geido commented on code in PR #27030:
URL: https://github.com/apache/superset/pull/27030#discussion_r1482710646
##########
superset-frontend/src/components/AlteredSliceTag/index.tsx:
##########
@@ -167,7 +198,7 @@ export default class AlteredSliceTag extends
React.Component {
return safeStringify(value);
}
- renderModalBody() {
+ renderModalBody(): JSX.Element {
Review Comment:
```suggestion
renderModalBody(): React.ReactNode {
```
##########
superset-frontend/src/components/AlteredSliceTag/index.tsx:
##########
@@ -196,15 +227,15 @@ export default class AlteredSliceTag extends
React.Component {
);
}
- renderTriggerNode() {
+ renderTriggerNode(): JSX.Element {
Review Comment:
```suggestion
renderTriggerNode(): React.ReactNode {
```
##########
superset-frontend/src/components/AlteredSliceTag/index.tsx:
##########
@@ -196,15 +227,15 @@ export default class AlteredSliceTag extends
React.Component {
);
}
- renderTriggerNode() {
+ renderTriggerNode(): JSX.Element {
return (
<Tooltip id="difference-tooltip" title={t('Click to see difference')}>
<StyledLabel className="label">{t('Altered')}</StyledLabel>
</Tooltip>
);
}
- render() {
+ render(): JSX.Element | null {
Review Comment:
```suggestion
render() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
