eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1483712249
##########
superset-frontend/src/dashboard/styles.ts:
##########
@@ -97,3 +111,43 @@ export const chartContextMenuStyles = (theme:
SupersetTheme) => css`
min-width: ${theme.gridUnit * 40}px;
}
`;
+
+export const focusStyle = (theme: SupersetTheme) => css`
+ a,
+ .ant-tabs-tabpane,
+ .ant-tabs-tab-btn,
+ .superset-button.action-button,
+ .superset-button.ant-dropdown-trigger,
+ .header-controls span {
+ &:focus-visible {
+ box-shadow: 0 0 0 2px ${theme.colors.primary.dark1};
+ border-radius: ${theme.gridUnit / 2}px;
+ outline: none;
+ text-decoration: none;
+ }
+ &:not(.superset-button, .ant-menu-item
+ a, .fave-unfave-icon, .ant-tabs-tabpane, .header-controls span) {
+ &:focus-visible {
+ padding: ${theme.gridUnit / 2}px;
+ }
+ }
+ }
+
+ @keyframes fadeOut {
Review Comment:
I think we're ok with the outline when someone tabs into an element, but it
just didn't feel right when clicking on an element, especially when the click
bubbles up to an outer element and you have no idea why the entire tab is
highlighting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
