kgabryje commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1488285460
##########
superset-frontend/src/components/ErrorMessage/ErrorAlert.tsx:
##########
@@ -123,7 +123,7 @@ export default function ErrorAlert({
{!isExpandable && !description && (
<span
role="button"
- tabIndex={0}
+ tabIndex={-1}
Review Comment:
Why are we setting tab index to -1 (here and other places)? Doesn't it have
a negative effect on accessibility, since you can't navigate to it with tab
anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
