john-bodley commented on code in PR #24969:
URL: https://github.com/apache/superset/pull/24969#discussion_r1488790462
##########
superset/commands/database/ssh_tunnel/create.py:
##########
@@ -39,15 +40,10 @@ def __init__(self, database: Database, data: dict[str,
Any]):
self._properties = data.copy()
self._properties["database"] = database
+ @transaction(on_error=partial(on_error,
reraise=SSHTunnelCreateFailedError))
def run(self) -> Model:
- try:
- self.validate()
- ssh_tunnel = SSHTunnelDAO.create(attributes=self._properties,
commit=False)
Review Comment:
Seems kind of weird how the command didn't actually commit. I presume the
intent was the command was to be used in association with other commands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
