john-bodley commented on code in PR #24969:
URL: https://github.com/apache/superset/pull/24969#discussion_r1488802324
##########
superset/commands/dataset/update.py:
##########
@@ -58,19 +59,11 @@ def __init__(
self.override_columns = override_columns
self._properties["override_columns"] = override_columns
+ @transaction(on_error=partial(on_error, reraises=DatasetUpdateFailedError))
def run(self) -> Model:
self.validate()
- if self._model:
- try:
- dataset = DatasetDAO.update(
- self._model,
- attributes=self._properties,
- )
- return dataset
- except DAOUpdateFailedError as ex:
- logger.exception(ex.exception)
- raise DatasetUpdateFailedError() from ex
- raise DatasetUpdateFailedError()
Review Comment:
This was not reachable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
