michael-s-molina commented on code in PR #26907:
URL: https://github.com/apache/superset/pull/26907#discussion_r1490119878
##########
superset-frontend/.eslintrc.js:
##########
@@ -310,6 +351,24 @@ module.exports = {
'react/static-property-placement': 0, // disabled temporarily
'react-prefer-function-component/react-prefer-function-component': 1,
'prettier/prettier': 'error',
+ // disabling some things that come with the eslint 7->8 upgrade. Will
address these in a separate PR
Review Comment:
```suggestion
// TODO: Disabling some things that come with the eslint 7->8 upgrade.
Will address these in a separate PR.
```
##########
superset-frontend/.eslintrc.js:
##########
@@ -203,6 +226,22 @@ module.exports = {
],
'no-only-tests/no-only-tests': 'error',
'max-classes-per-file': 0,
+ // temporary rules to help with migration - please re-enable!
Review Comment:
```suggestion
// TODO: Temporary rules to help with migration - please re-enable!
```
##########
superset-frontend/.eslintrc.js:
##########
@@ -161,6 +162,28 @@ module.exports = {
'react/static-property-placement': 0, // re-enable up for discussion
'prettier/prettier': 'error',
'file-progress/activate': 1,
+ // delete me later: temporary rules to help with migration
Review Comment:
Maybe add a `TODO:` prefix to make it discoverable by IDEs?
```suggestion
// TODO: Delete me later. Temporary rules to help with migration.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
