Re: [PR] feat(storybook): Co-habitating/Upgrading Storybooks to v7 (dependency madness ensues) [superset]

Fri, 16 Feb 2024 09:17:17 -0800 


geido commented on PR #26907:
URL: https://github.com/apache/superset/pull/26907#issuecomment-1948933893

   > Thank you for all the hard work @rusackas!
   > 
   > While testing the PR, I found the following problems:
   > 
   > Some components are not rendering anymore:
   > 
   > <img alt="Screenshot 2024-02-15 at 08 52 26" width="1258" 
src="https://private-user-images.githubusercontent.com/70410625/305100518-146bd262-14d3-4d12-aa06-44a6c1676c09.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDgxMDM5NzEsIm5iZiI6MTcwODEwMzY3MSwicGF0aCI6Ii83MDQxMDYyNS8zMDUxMDA1MTgtMTQ2YmQyNjItMTRkMy00ZDEyLWFhMDYtNDRhNmMxNjc2YzA5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMjE2VDE3MTQzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUzMjk0NTcwZGQwNmI1NGVjM2IyZGJkOThlZTA1YTFhOTc5YjhkZjE5ZDNhOTFjMTgzOGVhNTFhNDlmYmMzZDcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0._adx_DUKO71-mketlblvligUlT4L62igVtDKsGGtIgM";>
 <img alt="Screenshot 2024-02-15 at 08 57 48" width="1165" 
src="https://private-user-images.githubusercontent.
 
com/70410625/305100700-8cb63406-7703-4965-9183-28c41c6c4696.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDgxMDM5NzEsIm5iZiI6MTcwODEwMzY3MSwicGF0aCI6Ii83MDQxMDYyNS8zMDUxMDA3MDAtOGNiNjM0MDYtNzcwMy00OTY1LTkxODMtMjhjNDFjNmM0Njk2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMjE2VDE3MTQzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBjZWZlN2ZmYzMyMDM1NDRiYjIwZmQ5M2QxNTk5NGU1MDQzMDQ5ODA5YjdkYmNmYzc2MDk5N2U0ZmIwMjEzYzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.qTlbve51XX_QngSHXn1jCvqK1gD8RaxKyC-LoH8rhBs">
   > Some components are rendering but their content is not: <img 
alt="Screenshot 2024-02-15 at 08 55 05" width="593" 
src="https://private-user-images.githubusercontent.com/70410625/305100854-e4d6b762-e639-4492-97ac-c527f5f5f013.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDgxMDM5NzEsIm5iZiI6MTcwODEwMzY3MSwicGF0aCI6Ii83MDQxMDYyNS8zMDUxMDA4NTQtZTRkNmI3NjItZTYzOS00NDkyLTk3YWMtYzUyN2Y1ZjVmMDEzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMjE2VDE3MTQzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI3YzRmZDE1ZmFjOTg5YzRmZjcyYTYyNzI1NGUzNDE2MzIwNWUxN2I5NjY3ODU3YzNjZTdiZmRiNTM3YjI2NmMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.DbNjZPfDw1x2U6pYyvybvgvEt_P73s2S3Z2IHw4Z4-c";>
   > Some controls that used to work are not rendering. In this example, sizes 
and styles were a select: <img alt="Screenshot 2024-02-15 at 08 56 31" 
width="1780" 
src="https://private-user-images.githubusercontent.com/70410625/305101036-0af73019-a291-4cbf-bd7b-52bf83993923.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDgxMDM5NzEsIm5iZiI6MTcwODEwMzY3MSwicGF0aCI6Ii83MDQxMDYyNS8zMDUxMDEwMzYtMGFmNzMwMTktYTI5MS00Y2JmLWJkN2ItNTJiZjgzOTkzOTIzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMjE2VDE3MTQzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ4MWQ5MzU4M2FkOTNkNGE1YzY3YWEyODgwMWY5Mzc1YWY4MzE4NGQwMjNiZTA2MjczYWJlN2RkZmNjMzljNTcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.hDN9W3F_6HVIyAvwr3Ub0q_OiruqPQk6lD8hnDZhUa4";>
   > Some plugins are overflowing the render area: <img alt="Screenshot 
2024-02-15 at 08 58 45" width="1158" 
src="https://private-user-images.githubusercontent.com/70410625/305101631-472542cb-d808-43ce-baa7-7b0ef778357b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDgxMDM5NzEsIm5iZiI6MTcwODEwMzY3MSwicGF0aCI6Ii83MDQxMDYyNS8zMDUxMDE2MzEtNDcyNTQyY2ItZDgwOC00M2NlLWJhYTctN2IwZWY3NzgzNTdiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMjE2VDE3MTQzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ4OGMzNGFlY2EzZDFiMmE4OWM5NWNkODlmYTUyODA3YTlhODJhZTFlNGQyMjE4ZjE0ODA2ODU0M2MxN2FmMjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.FDGjQWEmDISFqpFU9psyrzHUg3ssscq-WiR1jaEr2r0";>
 <img alt="Screenshot 2024-02-15 at 08 59 06" width="1018" src="
 
https://private-user-images.githubusercontent.com/70410625/305101635-77977921-e299-4a6b-b119-078bc605ea3a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDgxMDM5NzEsIm5iZiI6MTcwODEwMzY3MSwicGF0aCI6Ii83MDQxMDYyNS8zMDUxMDE2MzUtNzc5Nzc5MjEtZTI5OS00YTZiLWIxMTktMDc4YmM2MDVlYTNhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMjE2VDE3MTQzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI4NTcxNTFlZjE3N2IwZTRmODA3NTE3M2Q4NDU4MThlYTY5ZTgxNjVhYjUxNDA3NWY2MWQ2ZTc1MzBkNjNlNWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.hiDgEft70dtWICkOGaO_-mcL3shXToJAF0J6-o9Cauw";>
   > This list is not exhaustive, as I only tested a sample of the stories. I 
can confirm that these problems don't happen on master. Given the size of the 
PR and the possibility of conflicts, I'm ok with merging it as is and tackling 
the problems in a follow-up given that the Storybook is an isolated area.
   > 
   > Amazing work 👏🏼
   
   Tracking this here 
https://github.com/orgs/apache/projects/315/views/1?pane=issue&itemId=53539080


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to