john-bodley commented on code in PR #27149: URL: https://github.com/apache/superset/pull/27149#discussion_r1496300835
########## tests/integration_tests/access_tests.py: ########## @@ -103,11 +103,7 @@ def tearDownClass(cls): db.session.delete(security_manager.find_role(SCHEMA_ACCESS_ROLE)) db.session.commit() - def setUp(self): - self.login("admin") - def tearDown(self): - self.logout() Review Comment: The logout is unnecessary as the client only persists for the lifetime of the test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org