john-bodley commented on code in PR #27149:
URL: https://github.com/apache/superset/pull/27149#discussion_r1498211342
##########
tests/integration_tests/base_tests.py:
##########
@@ -106,6 +106,9 @@ class SupersetTestCase(TestCase):
maxDiff = -1
+ def tearDown(self):
Review Comment:
The whole login/logout logic is convoluted given how our tests are defined.
Ideally there would be an `auth_user` context manager and an associated
`pytest` fixture which would be used to authenticate a user. Sadly this isn't
overly viable with the `pytest`/`unittest` mix we have and so, although
overkill—given that not every tests uses the API—this seemed like the best
mechanism (given that all `unittest` classes are derived from
`SupersetTestCase`) for ensuring that the tests are idempotent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
