eschutho commented on issue #27432: URL: https://github.com/apache/superset/issues/27432#issuecomment-1996193707
Thanks @michael-s-molina! Here are some answers. I am going to defer to a few other folks to help here: > 1. do we have tooltips explaining the meaning of them? I'm going to ask @yousoph for help on this one. > 2. Multiple time comparisons are supported in other chart types and are frequently used. Could you describe how are they going to work. The table and bar charts do not currently have time comparisons, which is why we started here, but for Bar and Line which do have time comparisons, we are looking to see how we can best improve the existing functionality and will do a separate SIP on those chart types. If we find a better way to integrate with the existing time filters, we may need to come back to this chart type and update the filters to match. Another reason why this is being developed behind a feature flag. > 3. How "Inherit range from time filters" behave when the time filter is set to `No filter`? Good question. A time filter is required in order for inherit to work. > 4. In all other chart types, time shifts are inside the Advanced Analytics panel. Here we are proposing to show them in a different section. When we first looked at this chart type, the time shifts didn't seem like advanced analytics. So similar answer to above, there's likely going to be some work during Bar and Line to unify these, and we will definitely have more answers about that in the next SIP. > 5. I understand that the current implementation of time shifts is limited and not flexible as the one we are proposing here. ...would be possible to change this globally? Yes, that would be the goal. > 6. Could you expand on what are the required changes for our query API/concepts? The required changes for the api are actually very limited, as the advanced analytics already perform this time shift comparison. The only new addition that I noted was that we thought it would be helpful to show what the resulting time range would be. I've updated the sip with that info. For the other api changes, those aren't a result of this feature, but rather from a bug that was found in the existing visualizations that we wanted to fix. I filed a [bug report](https://github.com/apache/superset/issues/27504) for the issue found with how the data is being fetched, and we can discuss the best solution in that ticket or a separate SIP if that's necessary. > 7. Given that Big Number was introduced without a SIP, can we apply the resulting changes of this discussion to that plugin as well to ensure consistency? Yes, of course. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
