zhaoyongjie commented on issue #27432: URL: https://github.com/apache/superset/issues/27432#issuecomment-2004132245
> Would it work without populating such column? If not, what would be the easiest/clearest way to help user to set it properly and read the table's data if they don't want to have such column displayed? It might be a UI/UX topic, i'm not very familiar with that. > IIRC the main difference it's not the multiple ranges support but rather the shift arg that's not supported by the current endpoint. If we want to pass two ranges (current and shifted) we would have to build the shifted range in the frontend as proposed here https://github.com/apache/superset/pull/27386, but as stated there, the backend will have to build the shifted ranges too at some point so we could either duplicate logic in frontend and backend or just pass the range in the api call? Not true, **even though** to build shifted time range in backend and follow all your designs, the original endpoint also easily extend to add "shift" offset, I've added [comment](https://github.com/apache/superset/pull/27370/files#r1510306968) at schema of time range ``` humanize_time_range = [ {"timeRange": "2021-01-01 : 2022-02-01"}, {"timeRange": "2022-01-01 : 2023-02-01", "shift": "some-time-delta"}, {"timeRange": "2022-01-01 : 2023-02-01", "shift": "some-time-delta"}, {"timeRange": "2022-01-01 : 2023-02-01", "shift": "some-time-delta"}, ] uri = f"api/v1/time_range/?q={prison.dumps(humanize_time_range)}" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
