rusackas commented on code in PR #27906: URL: https://github.com/apache/superset/pull/27906#discussion_r1560036976
########## .github/workflows/no-op.yml: ########## @@ -0,0 +1,96 @@ +# no-op.yml +# +# Purpose: +# This workflow provides a workaround for the "required status checks" feature in GitHub Actions +# when using path-specific conditions in other workflows. Required checks might remain in a "Pending" +# state if the conditions are not met, thus blocking pull requests from being merged. +# This no-op (no operation) workflow provides dummy success statuses for these required jobs when +# the real jobs do not run due to path-specific conditions. +# +# How it works: +# - It defines jobs with the same names as the required jobs in the main workflows. +# - These jobs simply execute a command (`exit 0`) to succeed immediately. +# - When a pull request is created or updated, both this no-op workflow and the main workflows are triggered. +# - If the main workflows' jobs don't run (due to path conditions), these no-op jobs provide successful statuses. +# - If the main workflows' jobs do run and fail, their failure statuses take precedence, +# ensuring that pull requests are not merged with failing checks. +# +# Usage: +# - Ensure that the job names in this workflow match exactly the names of the corresponding jobs in the main workflows. +# - This workflow should be kept as-is, without path-specific conditions. + +name: no-op Checks +on: pull_request + +jobs: + frontend-build: + runs-on: ubuntu-latest + steps: + - name: No-op for frontend-build + run: exit 0 + Review Comment: There are some inconsistent breaks between blocks if we want to get all OCD here. I wonder: would it be a problem to add ALL required checks here? If so, I wonder if we could ingest and iterate through the list from asf.yaml rather than having to maintain this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
