mistercrunch commented on code in PR #27906:
URL: https://github.com/apache/superset/pull/27906#discussion_r1560082354
##########
.github/actions/setup-backend/action.yml:
##########
@@ -13,22 +13,39 @@ inputs:
description: 'Type of requirements to install. Options: base, development,
default'
required: false
default: 'dev'
+ install-superset:
+ description: 'Whether to install Superset itself. If false, only python is
installed'
+ required: false
+ default: 'true'
runs:
using: 'composite'
steps:
- - name: Set up Python ${{ inputs.python-version }}
+ - name: Interpret Python Version
+ id: set-python-version
+ shell: bash
+ run: |
+ if [ "${{ inputs.python-version }}" = "current" ]; then
+ echo "PYTHON_VERSION=3.10" >> $GITHUB_ENV
Review Comment:
OMG YES! But GHA doesn't play nicely with that kind of parameter injection.
Composition through the "reusable action" approach that we have here is the
best we can do with basic actions (calling a reusable action that hard-codes
the values).
If we wanted more flexibility I'd suggest a Jinja2-based approach, where
we'd have the source templates in say a `.github/jinja` folder, and render that
into `.github/` via a commit hook or similar. Seemed overkill for now, but I'd
be supportive to move in that direction.
Now comparing to where we were a few months back, we're at a much better
place with this setup-backend and setup-supersetbot approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
