john-bodley commented on code in PR #28341: URL: https://github.com/apache/superset/pull/28341#discussion_r1589909312
########## tests/integration_tests/datasets/api_tests.py: ########## @@ -660,7 +661,11 @@ def test_create_dataset_validate_uniqueness(self): assert rv.status_code == 422 data = json.loads(rv.data.decode("utf-8")) assert data == { - "message": {"table_name": ["Dataset energy_usage already exists"]} + "message": { + "table": [ + f"Dataset {Table(energy_usage_ds.table_name, schema)} already exists" Review Comment: The schema differs between SQLite and PostgreSQL and thus this is parameterized. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org