john-bodley commented on code in PR #28341:
URL: https://github.com/apache/superset/pull/28341#discussion_r1591087760
##########
superset/commands/dataset/create.py:
##########
@@ -61,17 +61,16 @@ def run(self) -> Model:
def validate(self) -> None:
exceptions: list[ValidationError] = []
database_id = self._properties["database"]
- table_name = self._properties["table_name"]
schema = self._properties.get("schema")
catalog = self._properties.get("catalog")
sql = self._properties.get("sql")
owner_ids: Optional[list[int]] = self._properties.get("owners")
- table = Table(table_name, schema, catalog)
+ table = Table(self._properties["table_name"], schema, catalog)
Review Comment:
@michael-s-molina personally I try to remove single use variables (where
possible) as I find it easier to read/grok the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
